Remove doc strings from cli/js TS files #4329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ry
approved these changes
Mar 12, 2020
There was a problem hiding this comment.
@crowlKats Thanks LGTM
For anyone confused about this, we currently have docstrings in duplicated two places in cli/js/lib.deno_ns.d.ts and on the methods themselves. This becomes confusing - people don't know where the source of truth is.
|
@crowlKats make sure to run |
bartlomieju
approved these changes
Mar 13, 2020
dubiousjim
added a commit
to dubiousjim/deno
that referenced
this pull request
Mar 13, 2020
* denoland/master: Remove doc strings from cli/js TS files (denoland#4329) upgrade: Rust 1.42.0 (denoland#4331) Enable std tests in debug mode (denoland#4332) fix: Node polyfill fsAppend rework (denoland#4322) v0.36.0 Add waker to StreamResource to fix hang on close bugs (denoland#4293) reorg: Deno global initialization (denoland#4317) move compiler API tests to integration tests (denoland#4319) support permission mode in mkdir (denoland#4286) Stricter permissions for Deno.makeTemp* (denoland#4318) reorg: remove dispatch.ts, move signals, factor out web utils (denoland#4316) reorg: cli/js/compiler/, move more API to cli/js/web/ (denoland#4310) Improve dprint config (denoland#4314) doc(cli/flags): Reduce empty lines in help messages (denoland#4312)
dubiousjim
added a commit
to dubiousjim/deno
that referenced
this pull request
Mar 13, 2020
* denoland/master: Remove doc strings from cli/js TS files (denoland#4329) upgrade: Rust 1.42.0 (denoland#4331)
dubiousjim
added a commit
to dubiousjim/deno
that referenced
this pull request
Mar 13, 2020
* denoland/master: Remove doc strings from cli/js TS files (denoland#4329) upgrade: Rust 1.42.0 (denoland#4331)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4326